-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed E2 spawn behavior to only run once ever #3215
base: master
Are you sure you want to change the base?
Conversation
Bit controversial, but I see more good then bad in that |
Might break a lot of chips |
I think the policy for compatibility breaks calls for community involvement |
I'm not sure how many E2s out in the wild rely on doing something different between |
It seems to be |
That said... behavior differences depending on 'strict' also sounds really strange. It makes sense for 'strict' to invoke errors or warnings, but to function differently when duping is kind of uncanny. |
Well, behavioral differences is kinda already a thing with persist/global scope vars. Tho it would make more sense to have API versioning instead of strict mode, so we can forget about backwards compatibilities on major releases |
Out of 112 polled, the majority (86) voted to accept this behavior. |
If
AdvDupe2
is undefined,duped()
will always run,else,
duped()
will only run if the chip is not strict.This also changes
duped()
anddupefinished()
to be synonymous when AdvDupe2 is installed. Both will be1
when thedupefinished()
case is ran. Although it's not equivalent (becauseduped()
is ran before constraints are created), you can now useduped()
to flag both post-AdvDupe2 and regular post-dupe.I'm not sure if this is the best solution, but AdvDupe2 is the only addon that provides a hook to run after all of pasting is finished for both the normal and alternate duplicator.